sin P = 24/26
cos P = 10/26
tan P = 24/10
sin Q = 10/26
cos Q = 24/26
tan Q = 10/24
you have the first part right. using Soh Cah Toa is the best way to find the trig function when given a labeled triangle.
remember the hypotenuse is the longest side and always across from the 90 degree angle.