This is a correct way to ask for feedback. You need feedback if you are to grow as a worker and do things better. If you just plainly ask it you may seem rude or arrogant or anything similar, so it is a good idea to ask whether you're doing something good and get feedback so that you may improve in the future.